Thread (2 messages) flat view 2 messages, 2 authors, 2021-02-03

Re: [PATCH 1/2] diffcore-rename: no point trying to find a match better than exact

From: Junio C Hamano <hidden>
Date: 2021-02-03 18:47:23

Derrick Stolee [off-list ref] writes:
quoted
 	/* All done? */
-	if (!num_destinations)
+	if (!num_destinations || !num_sources)
 		goto cleanup;
And add an extra quit condition which is very possible to hit.
Is it only hit when every "delete" is actually a rename?
When every delete is actually an unmodified exact rename, I think.
If this simple change gives us good performance gain, that is
superb.

Nicely done.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help