[PATCH 1/3] pager: test for exit code
flat view
STALE2071d
From: Ævar Arnfjörð Bjarmason <hidden>
Date: 2021-02-01 14:55:19
Subsystem:
the rest · Maintainer:
Linus Torvalds
Add tests for how git behaves when the pager itself exits with non-zero, as well as for us exiting with 141 when we're killed with SIGPIPE due to the pager not consuming its output. There is some recent discussion[1] about these semantics, but aside from what we want to do in the future, we should have a test for the current behavior. This test construct is stolen from 7559a1be8a0 (unblock and unignore SIGPIPE, 2014-09-18). 1. https://lore.kernel.org/git/87o8h4omqa.fsf@evledraar.gmail.com/ (local) Signed-off-by: Ævar Arnfjörð Bjarmason <redacted> --- t/t7006-pager.sh | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+)
diff --git a/t/t7006-pager.sh b/t/t7006-pager.sh
index fdb450e446a..c60886f43e6 100755
--- a/t/t7006-pager.sh
+++ b/t/t7006-pager.sh@@ -656,4 +656,31 @@ test_expect_success TTY 'git tag with auto-columns ' ' test_cmp expect actual ' +test_expect_success TTY,!MINGW 'git returns SIGPIPE on early pager exit' ' + test_when_finished "rm pager-used" && + test_config core.pager ">pager-used; head -n 1; exit 0" && + + OUT=$( ((test_terminal git log; echo $? 1>&3) | :) 3>&1 ) && + test_match_signal 13 "$OUT" && + test_path_is_file pager-used +' + +test_expect_success TTY,!MINGW 'git returns SIGPIPE on early pager non-zero exit' ' + test_when_finished "rm pager-used" && + test_config core.pager ">pager-used; head -n 1; exit 1" && + + OUT=$( ((test_terminal git log; echo $? 1>&3) | :) 3>&1 ) && + test_match_signal 13 "$OUT" && + test_path_is_file pager-used +' + +test_expect_success TTY,!MINGW 'git discards pager non-zero exit' ' + test_when_finished "rm pager-used" && + test_config core.pager "wc >pager-used; exit 1" && + + OUT=$( ((test_terminal git log; echo $? 1>&3) | :) 3>&1 ) && + test "$OUT" -eq 0 && + test_path_is_file pager-used +' + test_done
--
2.30.0.284.gd98b1dd5eaa7