Thread (1 message) 1 message, 1 author, 2021-01-29

Re: [PATCH 05/10] p5303: measure time to repack with keep

From: Junio C Hamano <hidden>
Date: 2021-01-29 23:13:56

Jeff King [off-list ref] writes:
On Fri, Jan 29, 2021 at 12:38:08PM -0800, Junio C Hamano wrote:
quoted
quoted
Oops. Looks like I was the one who introduced that. Nobody seems to have
complained, so I'm somewhat tempted to leave it. But it would not be too
hard to replace with perl, I think.
Yeah, but would it be worth it?  I am actually OK to say that you
need GNU sed if you want to run perf.  We already rely on GNU time
to run perf tests, no?
True. This one is a little worse because it's subtle, and somebody might
copy it unknowingly into the regular test suite.

I am happy to leave it, or for you to pick up the patch I sent earlier
(which I did verify produces identical output).
Yeah, I would be very unhappy if somebody copied-and-pasted it, but
somehow I didn't think too many people moved code in that direction
;-)

Will apply the portability fix, then.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help