Thread (21 messages) 21 messages, 4 authors, 2021-02-19

Re: [PATCH 1/3] commit-reach: use one walk in remove_redundant()

flat view

From: René Scharfe <hidden>
Date: 2021-01-29 17:14:39

Am 28.01.21 um 17:24 schrieb Derrick Stolee via GitGitGadget:
+	/* rearrange array */
+	dup = xcalloc(cnt, sizeof(struct commit *));
You could use CALLOC_ARRAY instead here, which is shorter and uses the
correct type automatically.  Or -- seeing that the next line overwrites
all items anyway --  ALLOC_ARRAY.
+	COPY_ARRAY(dup, array, cnt);
René
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help