Re: [PATCH] ci: do not cancel all jobs of a matrix if one fails

From
Johannes Schindelin <hidden>
Date
2021-01-28 16:16:21
Reply to
Jeff King, 2021-01-28
Hi,

On Thu, 28 Jan 2021, Jeff King wrote:
On Thu, Jan 28, 2021 at 04:06:08AM +0000, Philippe Blain via GitGitGadget wrote:
quoted
From: Philippe Blain <redacted>

The CI/PR GitHub Actions workflow uses the 'matrix' strategy for the
"windows-test", "vs-test", "regular" and "dockerized" jobs. The default
behaviour of GitHub Actions is to cancel all in-progress jobs in a
matrix if one of the job of the matrix fails [1].

This is not ideal as a failure early in a job, like during installation of
the build/test dependencies on a specific platform, leads to the
cancellation of all other jobs in the matrix.

Set the 'fail-fast' variable to 'false' for all four matrix jobs in the
workflow.
I think this is worth doing.
Me, too. ACK!

Thanks,
Dscho
Thread (3 messages) 3 messages, 3 authors, 2021-01-28
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help