Re: [PATCH 1/4] Makefile: refactor assignment for subsequent change
From: Junio C Hamano <hidden>
Date: 2021-01-27 04:20:40
Ævar Arnfjörð Bjarmason [off-list ref] writes:
Refactor a multi-line assignment into a form that'll lend itself better to having "ifdef" split it up in a follow-up commit.
Hmph, it would do even better to start with an empty definition without treating the first one specially, i.e. ...
quoted hunk
Signed-off-by: Ævar Arnfjörð Bjarmason <redacted> --- Makefile | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)diff --git a/Makefile b/Makefile index 4edfda3e009..36c7b8fa08b 100644 --- a/Makefile +++ b/Makefile@@ -656,10 +656,10 @@ clean-perl-script: clean-python-script: $(RM) $(SCRIPT_PYTHON_GEN) -SCRIPTS = $(SCRIPT_SH_GEN) \ - $(SCRIPT_PERL_GEN) \ - $(SCRIPT_PYTHON_GEN) \ - git-instaweb +SCRIPTS = $(SCRIPT_SH_GEN)
... if this becomes ... SCRIPTS = SCRIPTS += $(SCRIPT_SH_GEN) ... instead, no?
+SCRIPTS += $(SCRIPT_PERL_GEN) +SCRIPTS += $(SCRIPT_PYTHON_GEN) +SCRIPTS += git-instaweb ETAGS_TARGET = TAGS