Re: [PATCH 1/3] range-diff: refactor check for commit range

Hi Phillip,

On Sat, 23 Jan 2021, Phillip Wood wrote:

On 22/01/2021 21:59, Junio C Hamano wrote:

quoted

Phillip Wood [off-list ref] writes:

quoted

quoted

   +static int is_range(const char *range)
+{
+	return !!strstr(range, "..");
+}

If the user wrongly passes two arguments referring to single commits
with `:/<text>` or `@{/<text>}` where text contains ".." this will
give a false positive.

True.  I do not think this aims to be complete revision parser in
the first place, though.

Yes but it affects the error message given to the user.

True. But my patch series does not try to fix that (it is not an issue
_introduced_ by this patch series, it was there all along).

Ciao,
Dscho