Re: [PATCH v6 00/11] [GSoC] Implement Corrected Commit Date

On Mon, Jan 18, 2021 at 04:04:14PM -0500, Derrick Stolee wrote:

On 1/16/2021 1:11 PM, Abhishek Kumar via GitGitGadget wrote:

quoted

This patch series implements the corrected commit date offsets as generation
number v2, along with other pre-requisites.

...

quoted

Changes in version 6:

 * Fixed typos in commit message for "commit-graph: implement corrected
   commit date".
 * Removed an unnecessary else-block in "commit-graph: implement corrected
   commit date".
 * Validate mixed generation chain correctly while writing in "commit-graph:
   use generation v2 only if the entire chain does".
 * Die if the GDAT chunk indicates data has overflown but there are is no
   generation data overflow chunk.

I checked the range-diff and looked once more through the patch
series. This version is good to go by my standards.

Reviewed-by: Derrick Stolee <redacted>

Thanks, Abhishek!

Thanks a lot for the review and continued guidance through out the
patch series!

- Abhishek