Thread (1 message) 1 message, 1 author, 2021-01-21

Re: [PATCH 09/10] builtin/repack.c: extract loose object handling

From: Junio C Hamano <hidden>
Date: 2021-01-21 03:51:06

Derrick Stolee [off-list ref] writes:
On 1/19/2021 6:24 PM, Taylor Blau wrote:
quoted
'git repack -g' will have to learn about unreachable loose objects that
This reference to the '-g' option is one patch too early. Perhaps
say

  An upcoming patch will introduce geometric repacking. This will
  require removing unreachable loose objects in a separate path
  from the existing checks.

or similar?
Yeah, sounds like a trivially obvious improvement to me.  

It does not matter to reviewers who are very well aware that the
series is about adding "repack -g", but it may end up being
confusing when somebody tries to see what commit the feature was
added later when the help from the cover letter is not available.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help