Re: [PATCH 8/9] test-lib: test_region looks for trace2 regions

On 1/20/2021 1:20 PM, Elijah Newren wrote:

On Wed, Jan 20, 2021 at 8:54 AM Derrick Stolee via GitGitGadget
[off-list ref] wrote:

...

quoted

        # t0212/parse_events.perl intentionally omits regions and data.
-       grep -e "region_enter" -e "\"category\":\"progress\"" trace.event &&
-       grep -e "region_leave" -e "\"category\":\"progress\"" trace.event &&
+       test_region category progress trace.event &&

Sidenote: Hmm...about 40% of my region labels in merge-ort.c and 90%
in diffcore-rename.c have spaces in them.  This function could still
be used, but I'm curious if I should change the labels (but then
again, they are testing logical regions rather than individual
functions, and the spaces instead of underscores kind of convey
that...)

You should be able to use

	test_region "category with spaces" "progress with spaces" trace

but if not, then the test_region helper could be improved to match.

I do think that it's better to avoid spaces in these identifiers.

Thanks,
-Stolee