Re: What's cooking in git.git (Jan 2021, #02; Fri, 8)
flat view
From: Jeff King <hidden>
Date: 2021-01-15 19:52:48
On Fri, Jan 08, 2021 at 11:22:23AM -0800, Junio C Hamano wrote:
* ps/config-env-pairs (2021-01-06) 8 commits - config: allow specifying config entries via envvar pairs - environment: make `getenv_safe()` a public function - config: parse more robust format in GIT_CONFIG_PARAMETERS - config: store "git -c" variables using more robust format - config: extract function to parse config pairs - quote: make sq_dequote_step() a public function - config: add new way to pass config via `--config-env` - git: add `--super-prefix` to usage string Introduce two new ways to feed configuration variable-value pairs via environment variables, and tweak the way GIT_CONFIG_PARAMETERS encodes variable/value pairs to make it more robust. Ready for 'next'?
I looked over the first 7, and noticed two of the patches are flipped in roder (I sent a separate reply in the thread, but I wanted to catch your attention, since I guess this may be on the list for integrating today). I didn't see any problems in the code of the 8th one, but I didn't spend a lot of brain power thinking about the overall design. I feel like that was hashed out pretty well in the early discussions, though. -Peff