Re: [PATCH 04/11] sha1dc: mark forgotten message for translation
From: Jeff King <hidden>
Date: 2021-01-12 11:38:10
On Tue, Jan 12, 2021 at 08:47:35AM +0000, Johannes Schindelin via GitGitGadget wrote:
quoted hunk ↗ jump to hunk
diff --git a/sha1dc_git.c b/sha1dc_git.c index 5c300e812e0..fecf5da1483 100644 --- a/sha1dc_git.c +++ b/sha1dc_git.c@@ -18,7 +18,7 @@ void git_SHA1DCFinal(unsigned char hash[20], SHA1_CTX *ctx) { if (!SHA1DCFinal(hash, ctx)) return; - die("SHA-1 appears to be part of a collision attack: %s", + die(_("SHA-1 appears to be part of a collision attack: %s"), hash_to_hex_algop(hash, &hash_algos[GIT_HASH_SHA1]));
I didn't find any list discussion, but I think I may have actually left this untranslated intentionally. Like a BUG(), we'd expect it to come up basically never. And when it does, being able to search for the exact wording online may be more important than providing a translated version. It probably doesn't matter that much either way, though. -Peff