Re: [PATCH v2 2/5] gpg-interface: improve interface for parsing tags
From: Junio C Hamano <hidden>
Date: 2021-01-12 05:25:28
Subsystem:
the rest · Maintainer:
Linus Torvalds
Possibly related (same subject, not in this thread)
- 2021-01-11 · [PATCH v2 2/5] gpg-interface: improve interface for parsing tags · brian m. carlson <hidden>
"brian m. carlson" [off-list ref] writes:
quoted hunk
diff --git a/ref-filter.c b/ref-filter.c index aa260bfd09..8d8baec1b5 100644 --- a/ref-filter.c +++ b/ref-filter.c@@ -1215,7 +1215,13 @@ static void find_subpos(const char *buf, unsigned long *nonsiglen, const char **sig, unsigned long *siglen) {
I think a preliminary clean-up should look like this. Tonight's tip of 'seen' contains this at the tip of your topic. https://github.com/git/git/actions/runs/479421349 Thanks.
diff --git a/ref-filter.c b/ref-filter.c
index 32ed4d5111..e6c8106377 100644
--- a/ref-filter.c
+++ b/ref-filter.c@@ -1210,10 +1210,10 @@ static void grab_person(const char *who, struct atom_value *val, int deref, void } static void find_subpos(const char *buf, - const char **sub, unsigned long *sublen, - const char **body, unsigned long *bodylen, - unsigned long *nonsiglen, - const char **sig, unsigned long *siglen) + const char **sub, size_t *sublen, + const char **body, size_t *bodylen, + size_t *nonsiglen, + const char **sig, size_t *siglen) { struct strbuf payload = STRBUF_INIT; struct strbuf signature = STRBUF_INIT;
@@ -1291,7 +1291,7 @@ static void grab_sub_body_contents(struct atom_value *val, int deref, void *buf) { int i; const char *subpos = NULL, *bodypos = NULL, *sigpos = NULL; - unsigned long sublen = 0, bodylen = 0, nonsiglen = 0, siglen = 0; + size_t sublen = 0, bodylen = 0, nonsiglen = 0, siglen = 0; for (i = 0; i < used_atom_cnt; i++) { struct used_atom *atom = &used_atom[i];