[PATCH 00/20] pack-revindex: prepare for on-disk reverse index · Taylor Blau <hidden> · 2021-01-08
[PATCH 01/20] pack-revindex: introduce a new API · Taylor Blau <hidden> · 2021-01-08
Re: [PATCH 01/20] pack-revindex: introduce a new API · Jeff King <hidden> · 2021-01-12
Re: [PATCH 01/20] pack-revindex: introduce a new API · Jeff King <hidden> · 2021-01-12
Re: [PATCH 01/20] pack-revindex: introduce a new API · Taylor Blau <hidden> · 2021-01-12
[PATCH 02/20] write_reuse_object(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-08
Re: [PATCH 02/20] write_reuse_object(): convert to new revindex API · Jeff King <hidden> · 2021-01-12
Re: [PATCH 02/20] write_reuse_object(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-12
Re: [PATCH 02/20] write_reuse_object(): convert to new revindex API · Jeff King <hidden> · 2021-01-13
[PATCH 03/20] write_reused_pack_one(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-08
Re: [PATCH 03/20] write_reused_pack_one(): convert to new revindex API · Jeff King <hidden> · 2021-01-12
Re: [PATCH 03/20] write_reused_pack_one(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-12
[PATCH 04/20] write_reused_pack_verbatim(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-08
Re: [PATCH 04/20] write_reused_pack_verbatim(): convert to new revindex API · Jeff King <hidden> · 2021-01-12
[PATCH 06/20] bitmap_position_packfile(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-08
[PATCH 08/20] get_size_by_pos(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-08
[PATCH 07/20] show_objects_for_type(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-08
Re: [PATCH 07/20] show_objects_for_type(): convert to new revindex API · Jeff King <hidden> · 2021-01-12
Re: [PATCH 07/20] show_objects_for_type(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-12
[PATCH 05/20] check_object(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-08
Re: [PATCH 05/20] check_object(): convert to new revindex API · Derrick Stolee <hidden> · 2021-01-11
Re: [PATCH 05/20] check_object(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-11
Re: [PATCH 05/20] check_object(): convert to new revindex API · Jeff King <hidden> · 2021-01-12
Re: [PATCH 05/20] check_object(): convert to new revindex API · Jeff King <hidden> · 2021-01-12
[PATCH 11/20] get_delta_base_oid(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-08
[PATCH 12/20] retry_bad_packed_offset(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-08
[PATCH 16/20] builtin/gc.c: guess the size of the revindex · Taylor Blau <hidden> · 2021-01-08
Re: [PATCH 16/20] builtin/gc.c: guess the size of the revindex · Derrick Stolee <hidden> · 2021-01-11
Re: [PATCH 16/20] builtin/gc.c: guess the size of the revindex · Taylor Blau <hidden> · 2021-01-11
Re: [PATCH 16/20] builtin/gc.c: guess the size of the revindex · Derrick Stolee <hidden> · 2021-01-11
Re: [PATCH 16/20] builtin/gc.c: guess the size of the revindex · Jeff King <hidden> · 2021-01-12
[PATCH 15/20] for_each_object_in_pack(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-08
[PATCH 10/20] rebuild_existing_bitmaps(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-08
[PATCH 09/20] try_partial_reuse(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-08
Re: [PATCH 09/20] try_partial_reuse(): convert to new revindex API · Jeff King <hidden> · 2021-01-12
Re: [PATCH 09/20] try_partial_reuse(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-12
[PATCH 13/20] packed_object_info(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-08
Re: [PATCH 13/20] packed_object_info(): convert to new revindex API · Jeff King <hidden> · 2021-01-12
Re: [PATCH 13/20] packed_object_info(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-12
[PATCH 14/20] unpack_entry(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-08
Re: [PATCH 14/20] unpack_entry(): convert to new revindex API · Jeff King <hidden> · 2021-01-12
Re: [PATCH 14/20] unpack_entry(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-12
[PATCH 18/20] pack-revindex: remove unused 'find_revindex_position()' · Taylor Blau <hidden> · 2021-01-08
Re: [PATCH 18/20] pack-revindex: remove unused 'find_revindex_position()' · Derrick Stolee <hidden> · 2021-01-11
Re: [PATCH 18/20] pack-revindex: remove unused 'find_revindex_position()' · Taylor Blau <hidden> · 2021-01-11
Re: [PATCH 18/20] pack-revindex: remove unused 'find_revindex_position()' · Derrick Stolee <hidden> · 2021-01-11
Re: [PATCH 18/20] pack-revindex: remove unused 'find_revindex_position()' · Jeff King <hidden> · 2021-01-12
Re: [PATCH 18/20] pack-revindex: remove unused 'find_revindex_position()' · Taylor Blau <hidden> · 2021-01-12
Re: [PATCH 18/20] pack-revindex: remove unused 'find_revindex_position()' · Jeff King <hidden> · 2021-01-13
[PATCH 19/20] pack-revindex: hide the definition of 'revindex_entry' · Taylor Blau <hidden> · 2021-01-08
Re: [PATCH 19/20] pack-revindex: hide the definition of 'revindex_entry' · Derrick Stolee <hidden> · 2021-01-11
Re: [PATCH 19/20] pack-revindex: hide the definition of 'revindex_entry' · Jeff King <hidden> · 2021-01-12
[PATCH 17/20] pack-revindex: remove unused 'find_pack_revindex()' · Taylor Blau <hidden> · 2021-01-08
[PATCH 20/20] pack-revindex.c: avoid direct revindex access in 'offset_to_pack_pos()' · Taylor Blau <hidden> · 2021-01-08
Re: [PATCH 20/20] pack-revindex.c: avoid direct revindex access in 'offset_to_pack_pos()' · Jeff King <hidden> · 2021-01-12
Re: [PATCH 20/20] pack-revindex.c: avoid direct revindex access in 'offset_to_pack_pos()' · Taylor Blau <hidden> · 2021-01-12
Re: [PATCH 00/20] pack-revindex: prepare for on-disk reverse index · Derrick Stolee <hidden> · 2021-01-11
Re: [PATCH 00/20] pack-revindex: prepare for on-disk reverse index · Taylor Blau <hidden> · 2021-01-11
Re: [PATCH 00/20] pack-revindex: prepare for on-disk reverse index · Derrick Stolee <hidden> · 2021-01-11
Re: [PATCH 00/20] pack-revindex: prepare for on-disk reverse index · Taylor Blau <hidden> · 2021-01-11
Re: [PATCH 00/20] pack-revindex: prepare for on-disk reverse index · Jeff King <hidden> · 2021-01-12
Re: [PATCH 00/20] pack-revindex: prepare for on-disk reverse index · Taylor Blau <hidden> · 2021-01-12
[PATCH v2 00/20] pack-revindex: prepare for on-disk reverse index · Taylor Blau <hidden> · 2021-01-14
[PATCH v2 03/20] write_reused_pack_one(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-14
[PATCH v2 01/20] pack-revindex: introduce a new API · Taylor Blau <hidden> · 2021-01-14
Re: [PATCH v2 01/20] pack-revindex: introduce a new API · Junio C Hamano <hidden> · 2021-01-14
Re: [PATCH v2 01/20] pack-revindex: introduce a new API · Derrick Stolee <hidden> · 2021-01-14
Re: [PATCH v2 01/20] pack-revindex: introduce a new API · Taylor Blau <hidden> · 2021-01-14
Re: [PATCH v2 01/20] pack-revindex: introduce a new API · Jeff King <hidden> · 2021-01-14
[PATCH v2 20/20] pack-revindex.c: avoid direct revindex access in 'offset_to_pack_pos()' · Taylor Blau <hidden> · 2021-01-14
[PATCH v2 09/20] try_partial_reuse(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-14
[PATCH v2 15/20] for_each_object_in_pack(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-14
Re: [PATCH v2 15/20] for_each_object_in_pack(): convert to new revindex API · Junio C Hamano <hidden> · 2021-01-14
Re: [PATCH v2 15/20] for_each_object_in_pack(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-14
Re: [PATCH v2 15/20] for_each_object_in_pack(): convert to new revindex API · Jeff King <hidden> · 2021-01-14
Re: [PATCH v2 15/20] for_each_object_in_pack(): convert to new revindex API · Jeff King <hidden> · 2021-01-14
Re: [PATCH v2 15/20] for_each_object_in_pack(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-14
[PATCH v2 13/20] packed_object_info(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-14
[PATCH v2 16/20] builtin/gc.c: guess the size of the revindex · Taylor Blau <hidden> · 2021-01-14
[PATCH v2 19/20] pack-revindex: hide the definition of 'revindex_entry' · Taylor Blau <hidden> · 2021-01-14
[PATCH v2 17/20] pack-revindex: remove unused 'find_pack_revindex()' · Taylor Blau <hidden> · 2021-01-14
[PATCH v2 10/20] rebuild_existing_bitmaps(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-14
[PATCH v2 07/20] show_objects_for_type(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-14
[PATCH v2 11/20] get_delta_base_oid(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-14
[PATCH v2 12/20] retry_bad_packed_offset(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-14
[PATCH v2 14/20] unpack_entry(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-14
[PATCH v2 18/20] pack-revindex: remove unused 'find_revindex_position()' · Taylor Blau <hidden> · 2021-01-14
Re: [PATCH v2 18/20] pack-revindex: remove unused 'find_revindex_position()' · Junio C Hamano <hidden> · 2021-01-14
[PATCH v2 08/20] get_size_by_pos(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-14
[PATCH v2 04/20] write_reused_pack_verbatim(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-14
[PATCH v2 06/20] bitmap_position_packfile(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-14
[PATCH v2 02/20] write_reuse_object(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-14
[PATCH v2 05/20] check_object(): convert to new revindex API · Taylor Blau <hidden> · 2021-01-14
Re: [PATCH v2 00/20] pack-revindex: prepare for on-disk reverse index · Jeff King <hidden> · 2021-01-14

Re: [PATCH 00/20] pack-revindex: prepare for on-disk reverse index

From: Taylor Blau <hidden>
Date: 2021-01-11 16:31:41

On Mon, Jan 11, 2021 at 07:07:17AM -0500, Derrick Stolee wrote:

My comments on this series are very minor.

I made only one comment about "if (method() < 0)" versus
"if (method())" but that pattern appears in multiple patches.
_If_ you decide to change that pattern, then I'm sure you can
find all uses.

I have no strong opinion here, so I'm happy to defer to your or others'
judgement. My very weak opinion is that I'd just as soon leave it as-is,
but that if I'm rerolling and others would like to see it changed, then
I'm happy to do it.

Reviewed-by: Derrick Stolee <redacted>

Thank you for your review. I think that I owe you some as well,
somewhere in the near-2,000 emails that I still have :-/.

Thanks,
Taylor

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help