Re: Git 2.30.0 and failed self tests

On Sun, Jan 10, 2021 at 12:09 PM Stefan Moch [off-list ref] wrote:

Jeffrey Walton wrote:

quoted

I'm seeing some failed self tests with 2.30.0 on Fedora 33 x86_64
fully patched. They seem to be centered around email.

I cannot confirm this on the same git version and platform:

    # passed all 174 test(s)
    1..174

Christian's suggestion from your other thread about running the test
with the options -i -v -x should also help here to give more
detailed error messages:

https://lore.kernel.org/git/CAP8UFD30et-kL8dFoWvh7aPf4AKbzGxSzTuA=B3YNHZL_1axFA@mail.gmail.com/ (local)

quoted

    *** t9001-send-email.sh ***
    ok 1 - prepare reference tree
    ok 2 - Setup helper tool
    ok 3 - Extract patches
    not ok 4 - No confirm with --suppress-cc

Since the tests 1-3 do not call git send-email, but test 4 and most
of the following do, I suspect the system is missing some dependency
packages needed for git send-email, probably mail-related Perl modules.

Installing Fedora's git-email package is probably enough to fix this:

    dnf install git-email

It looks like a Perl problem.

I've got a Perl recipe for OpenSSL. The OpenSSL devs don't realize the
trouble they create with that dependency. Old systems need a newer
Perl for OpenSSL. The F33 machine is a test machine, so Perl gets
tested on it, too.

t$ ./t9001-send-email.sh -i -v -x
Initialized empty Git repository in
/home/jwalton/Build-Scripts/git-2.30.0/t/trash
directory.t9001-send-email/.git/
expecting success of 9001.1 'prepare reference tree':
    echo "1A quick brown fox jumps over the" >file &&
    echo "lazy dog" >>file &&
    git add file &&
    GIT_AUTHOR_NAME="A" git commit -a -m "Initial."

++ echo '1A quick brown fox jumps over the'
++ echo 'lazy dog'
++ git add file
++ GIT_AUTHOR_NAME=A
++ git commit -a -m Initial.
[master (root-commit) fbff2ba] Initial.
 Author: A [off-list ref]
 1 file changed, 2 insertions(+)
 create mode 100644 file
ok 1 - prepare reference tree

expecting success of 9001.2 'Setup helper tool':
    write_script fake.sendmail <<-\EOF &&
    shift
    output=1
    while test -f commandline$output
    do
        output=$(($output+1))
    done
    for a
    do
        echo "!$a!"
    done >commandline$output
    cat >"msgtxt$output"
    EOF
    git add fake.sendmail &&
    GIT_AUTHOR_NAME="A" git commit -a -m "Second."

++ write_script fake.sendmail
++ echo '#!/bin/sh'
++ cat
++ chmod +x fake.sendmail
++ git add fake.sendmail
++ GIT_AUTHOR_NAME=A
++ git commit -a -m Second.
[master 60cacbf] Second.
 Author: A [off-list ref]
 1 file changed, 12 insertions(+)
 create mode 100755 fake.sendmail
ok 2 - Setup helper tool

expecting success of 9001.3 'Extract patches':
    patches=$(git format-patch -s --cc="One [off-list ref]"
--cc=two@example.com -n HEAD^1) &&
    threaded_patches=$(git format-patch -o threaded -s
--in-reply-to="format" HEAD^1)

+++ git format-patch -s '--cc=One <one@example.com>'
--cc=two@example.com -n 'HEAD^1'
++ patches=0001-Second.patch
+++ git format-patch -o threaded -s --in-reply-to=format 'HEAD^1'
++ threaded_patches=threaded/0001-Second.patch

ok 3 - Extract patches

expecting success of 9001.4 'No confirm with --suppress-cc':
    test_no_confirm --suppress-cc=sob &&
    check_no_confirm

++ test_no_confirm --suppress-cc=sob
++ rm -f no_confirm_okay
++ echo n

+++ pwd
++ GIT_SEND_EMAIL_NOTTY=1
++ git send-email '--from=Example <from@example.com>'
--to=nobody@example.com

'--smtp-server=/home/jwalton/Build-Scripts/git-2.30.0/t/trash
directory.t9001-send-email/fake.sendmail' --suppress-cc=sob
0001-Second.patch
Can't locate Term/ReadLine.pm in @INC (you may need to install the
Term::ReadLine module) (@INC contains:
/home/jwalton/Build-Scripts/git-2.30.0/perl/build/lib
/home/jwalton/Build-Scripts/git-2.30.0/t/../perl/build/lib
/usr/local/lib64/perl5/5.32 /usr/local/share/perl5/5.32
/usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl
/usr/lib64/perl5 /usr/share/perl5) at
/home/jwalton/Build-Scripts/git-2.30.0/git-send-email line 25.
BEGIN failed--compilation aborted at
/home/jwalton/Build-Scripts/git-2.30.0/git-send-email line 25.
error: last command exited with $?=2
not ok 4 - No confirm with --suppress-cc
#
#        test_no_confirm --suppress-cc=sob &&
#        check_no_confirm

Jeff