Re: Is t5516 somehow flakey only on macOS?
From: Eric Sunshine <hidden>
Date: 2021-01-09 09:14:01
On Fri, Jan 8, 2021 at 7:39 PM Junio C Hamano [off-list ref] wrote:
I've seen this breakage only on "regular (osx-clang, clang, macos-latest)" so far, but that does not necessarily mean clang on macOS is miscompiling or anything like that. https://github.com/git/git/runs/1671504998?check_suite_focus=true Any interest in helping to find out what's going on from folks in the macOS land?
Something seems to be dying prematurely. The code in question from
test #86 "deny fetch unreachable SHA1, allowtipsha1inwant=false" is:
test_must_fail env GIT_TEST_PROTOCOL_VERSION=0 \
git fetch ../testrepo/.git $SHA1_3 2>err &&
test_i18ngrep "remote error:.*not our ref.*$SHA1_3\$" err
In a successful run, the content of `err` is:
fatal: git upload-pack: not our ref 64ea4c133d59fa98e86a771eda009872d6ab2886
fatal: remote error: upload-pack: not our ref
64ea4c133d59fa98e86a771eda009872d6ab2886
However, in the unsuccessful run from CI, it is:
fatal: git upload-pack: not our ref 64ea4c133d59fa98e86a771eda009872d6ab2886
fatal: unable to write to remote: Broken pipe
Perhaps this means something to someone familiar with this area of the code.