Re: [PATCH v2 4/5] mailmap: use case-sensitive comparisons for local-parts and names
From: Junio C Hamano <hidden>
Date: 2021-01-06 00:47:19
Ævar Arnfjörð Bjarmason [off-list ref] writes:
On Sun, Jan 03 2021, brian m. carlson wrote:
We just have to worry about cases where you're not all of these people
in one project's commit metadata and/or .mailmap, and thus mailmap rules
would match too generously:
"brian m. carlson" [off-list ref]
"brian m. carlson" [off-list ref]
"BRIAN M. CARLSON" [off-list ref]
"BRIAN M. CARLSON" [off-list ref]
Is that really plausible? In any case, neither of these two patches make
reference to us already having changed this in the past in 1.6.2 and &
there being reports on the ML about the bug & us changing it back. See
https://lore.kernel.org/git/f182fb1700e8dea15459fd02ced2a6e5797bec99.1238458535u.git.johannes.schindelin@gmx.de/ (local)
Maybe we should still do this, but I think for a v3 it makes sense to
summarize that discussion etc.After reading the old discussion again, I am not sure if this is worth doing. To many people, it is a promise we've made and kept that we treat addresses including the local part case-insensitively when summarising commits by ident strings. I'd really wish that this series were structured to have 5/5 early and 3&4/5 squashed into a single final patch.