Thread (2 messages) flat view 2 messages, 2 authors, 2021-01-05

Re: [PATCH] p7519: allow running without watchman prereq

From: Nipunn Koorapati <hidden>
Date: 2021-01-04 23:57:24

I could do without the 'else' block here, but it seems straightforward
enough. Likewise, the "ensure no silent error" comment could certainly
be removed (since 'test_must_be_empty error' makes what is happening
quite clear), but the fix pursued here is minimal.
This looks great to me. Thanks for fixing - and appreciate the else
clause here for the reader.

--Nipunn
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help