Thread (3 messages) 3 messages, 3 authors, 2020-12-27

Re: [PATCH] git-remote: load config whenever create_symref() might be called

From: Jérémie Detrey <hidden>
Date: 2020-12-26 22:28:55

Hi,

Thanks for the feedback!

Junio C Hamano:
My gut feeling says that the best place to call git_config() on
git_default_config would actually be in cmd_remote(), immediately
before we call parse_options() to parse the main options shared by
all subcommands of "git remote".  Is there a reason why codepaths
other than the three you singled out should *not* be affected by the
basic set of configuration variables?
No, none that I can think of. I'll leave more knowledgeable people
than me confirm this, but if that's the way to go, I'll be happy to
submit a revised patch following your suggestion :)

Cheers,
Jérémie.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help