Re: [PATCH v4 07/20] mktag tests: don't pipe to stderr needlessly
From: Junio C Hamano <hidden>
Date: 2020-12-23 02:11:12
Ævar Arnfjörð Bjarmason [off-list ref] writes:
Remove the piping of stderr to "message" in the valid tag test. This pattern seems to have been copy/pasted from the failure case in 446c6faec6 (New tests and en-passant modifications to mktag., 2006-07-29). Nothing is piped to "message" here, and in the event of the test failing it only serves to hide the error.
I think the verb "to pipe" specifically means "redirecting the
output to a pipe" and nothing else.
mktag tests: don't redirect stderr to a file needlessly
Remove the redirection of stderr to "message" in the valid tag
tests. This pattern ... 2006-07-29). Nobody examines the
contents of the resulting "message" file, so the net result is
that error messages cannot be seen in "sh t3800-mktag.sh -v"
output.
or something like that?
quoted hunk
Signed-off-by: Ævar Arnfjörð Bjarmason <redacted> --- t/t3800-mktag.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/t/t3800-mktag.sh b/t/t3800-mktag.sh index 9ae1b0bb0a..bbd148618e 100755 --- a/t/t3800-mktag.sh +++ b/t/t3800-mktag.sh@@ -257,7 +257,7 @@ EOF test_expect_success \ 'allow empty tag email' \ - 'git mktag <tag.sig >.git/refs/tags/mytag 2>message' + 'git mktag <tag.sig >.git/refs/tags/mytag' ############################################################ # 16. disallow spaces in tag email@@ -385,7 +385,7 @@ EOF test_expect_success \ 'create valid tag' \ - 'git mktag <tag.sig >.git/refs/tags/mytag 2>message' + 'git mktag <tag.sig >.git/refs/tags/mytag' ############################################################ # 25. check mytag