Thread (1 message) 1 message, 1 author, 2020-12-03

Re: [PATCH v1 09/27] diff-merges: re-arrange functions to match the order they are called in

From: Sergey Organov <hidden>
Date: 2020-12-03 15:42:58

Elijah Newren [off-list ref] writes:
On Sun, Nov 8, 2020 at 1:43 PM Sergey Organov [off-list ref] wrote:
quoted
For clarity, define public functions in the order they are called, to
make logic inter-dependencies easier to grok.
You added diff-merges.[ch] earlier in this series.  Why not just add
them in the correct order initially instead of adding another patch
later in the series?
Well, I did consider it, but there are 2 issues that stopped me.

First, I didn't want to rearrange functions as I move them from
revision.c, to avoid mixed commit to simplify review, and second, I
didn't want to rearrange them in the original to perform as little
changes to the codebase as possible before isolating my work
into diff-merges.[ch].

Hope it makes sense.

Thanks,
-- Sergey Organov
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help