Thread (1 message) 1 message, 1 author, 2020-12-01

Re: [PATCH v2 09/10] mktag: use fsck instead of custom verify_tag()

From: Junio C Hamano <hidden>
Date: 2020-12-01 22:28:55

Junio C Hamano [off-list ref] writes:
I do not see the "we do not want more than one blank line after the
header" in the original, which was one thing I was looking for after
seeing what 08/10 did.
quoted
+	fsck_options.extra = 1;
+	fsck_options.error_func = mktag_fsck_error_func;
Hmph, recent "released" versions of Git seems to be fine when
--- >8 ------ >8 ------ >8 ------ >8 ------ >8 ---
object 72ffeb997eaf999f6938b2a7e0d9a75dcceaa311
type commit
tag tester
tagger Junio C Hamano [off-list ref] 1606860947 -0800


a message after a blank
--- 8< ------ 8< ------ 8< ------ 8< ------ 8< ---
is fed to their "git mktag".  If I am not mistaken, we definitely
want to drop the EXTRA_HEADER_BODY_NEWLINE check from 08/10, even
though EXTRA_HEADER_ENTRY may be something we want to retain at
least for some releases for backward compatibility.


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help