Re: [PATCH 2/2] t3301: test proper exit response to no-value notes.displayRef.
From: Junio C Hamano <hidden>
Date: 2020-11-23 18:44:09
nate@roosteregg.cc writes:
quoted hunk
From: Nate Avers <redacted> Signed-off-by: Nate Avers <redacted> --- t/t3301-notes.sh | 5 +++++ 1 file changed, 5 insertions(+)diff --git a/t/t3301-notes.sh b/t/t3301-notes.sh index 8f43303007..ca60faf480 100755 --- a/t/t3301-notes.sh +++ b/t/t3301-notes.sh@@ -672,6 +672,11 @@ test_expect_success 'notes.displayRef respects order' ' test_cmp expect-both-reversed actual ' +test_expect_success 'notes.displayRef with no value handled gracefully' ' + test_must_fail git -c notes.displayRef log -0 --notes && + test_must_fail git -c notes.displayRef diff-tree --notes HEAD +'
Looks good. I didn't know we can feed the "no assignment means true" configuration from the command line with "git -c" ;-)
test_expect_success 'GIT_NOTES_DISPLAY_REF works' ' GIT_NOTES_DISPLAY_REF=refs/notes/commits:refs/notes/other \ git log -2 >actual &&