Thread (1 message) 1 message, 1 author, 2020-11-23

Re: [PATCH 1/2] notes.c: fix a segfault in notes_display_config()

From: Junio C Hamano <hidden>
Date: 2020-11-23 06:59:48

nate@roosteregg.cc writes:
 	if (*load_refs && !strcmp(k, "notes.displayref")) {
 		if (!v)
-			config_error_nonbool(k);
+			return config_error_nonbool(k);
"git grep config_error_nonbool" tells us that this is the only
instance that ignores the return value from the function and does
not cause the caller to die.

Looks good.  Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help