Thread (1 message) 1 message, 1 author, 2020-11-04

Re: Segfault in git when using git logs

From: Junio C Hamano <hidden>
Date: 2020-11-04 16:26:35

Jeff King [off-list ref] writes:
On Tue, Nov 03, 2020 at 12:21:42PM -0800, Junio C Hamano wrote:
quoted
quoted
quoted
So something like this won't harm VS Code more than we currently do,
while telling users what is wrong with their command line?
Yeah, I was wondering if we'd want the patch you sent, or if we should
turn those die() calls into warning() and disable the flags up front.
[...]
quoted
quoted
diff --git c/builtin/log.c w/builtin/log.c
Since we now have identified the caller that was passing in the bogus
options, and it has already been fixed, I'm inclined to say we should go
with your die() patch from earlier (modulo the pathspec.nr fixup) and
call it done.

Do you want to roll that up with a commit message?
OK, will try.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help