On Sat, 17 Oct 2020 at 20:44, Đoàn Trần Công Danh [off-list ref] wrote:
On 2020-10-17 13:24:52+0530, Charvi Mendiratta [off-list ref] wrote:
Welcome to the list.
quoted
Some tests use a deprecated style in which there are unnecessary blank lines after the opening quote of the test body and before the closing quote. So we should remove these unnecessary blank lines.
In Git project, we wrap the commit message's body to 72 columns per
line (for more information, please take a look at
Documentation/MyFirstContribution.txt).
Thanks a lot Danh, I will fix it in my editor's settings and will
update in the next patch series .
And we rarely say "we should", if the change shouldn't be applied,
it won't be applied.
Instead, we ask the code base to fix itself. Perhaps:
t7102 and t7201 still follow the old style of having blank
lines around test body, which is not consistence with our
current practice.
Let's remove those unnecessary blank lines.
Noted, will update this as well.
Thanks,
--
Danh
Thanks and Regards,
Charvi