Thread (6 messages) 6 messages, 2 authors, 2020-10-15

Re: [PATCH 2/4] t6423: more involved directory rename test

From: Eric Sunshine <hidden>
Date: 2020-10-15 20:57:49

On Thu, Oct 15, 2020 at 4:46 PM Elijah Newren via GitGitGadget
[off-list ref] wrote:
Add a new testcase modelled on a real world repository example that
served multiple purposes:
A couple minor style nits I noticed while quickly running my eye over
the patch...
+               for i in `test_seq 1 88`; do
+                       echo content $i >dir/unchanged/file_$i
+               done &&
'do' on its own line, and prefer $(...) over `...`:

    for i in $(test_seq 1 88)
    do
        echo content $i >dir/unchanged/file_$i
    done &&

(Not necessarily worth a re-roll, though.)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help