Thread (1 message) 1 message, 1 author, 2020-10-15

Re: [PATCH v2 1/3] test-lib: allow selecting tests by substring/regex with --run

From: Junio C Hamano <hidden>
Date: 2020-10-15 16:10:27

Elijah Newren [off-list ref] writes:
On Wed, Oct 14, 2020 at 10:57 AM Junio C Hamano [off-list ref] wrote:
quoted
quoted
are you suggesting dropping the regex handling and limit it to
substring matching?  In either case, does using expr save us anything
(isn't expr a shell command)?
I had something along this line in mind, not to do a regex but a glob.

case "$title" in $selector) found=1 ;; esac
Interesting.  Since it needs to handle substring searching (e.g.
./test-script.sh --run=setup,rename), I think this would need to be
tweaked to be
   case "$title" in *${selector}*) include=$positive ;; esac
Yup, of course we need to un-anchor with surrounding asterisks.
Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help