Re: [PATCH 3/3] http: automatically retry some requests

Johannes Schindelin [off-list ref] writes:

Hi Sean,

On Mon, 12 Oct 2020, Sean McAllister wrote:

quoted

Some HTTP response codes indicate a server state that can support
retrying the request rather than immediately erroring out.  The server
can also provide information about how long to wait before retries to
via the Retry-After header.  So check the server response and retry
some reasonable number of times before erroring out to better accomodate
transient errors.

Exiting immediately becomes irksome when pulling large multi-repo code
bases such as Android or Chromium, as often the entire fetch operation
has to be restarted from the beginning due to an error in one repo. If
we can reduce how often that occurs, then it's a big win.

Makes a lot of sense to me.
...

quoted

+http.retryLimit::
+	Some HTTP error codes (eg: 429,503) can reasonably be retried if

Please have a space after the comma so that it is not being mistaken for a
6-digit number. Also, aren't they called "status codes"? Not all of them
indicate errors, after all.
...

I've read your comments and agree to them all.  Thanks for a
detailed and excellent review.