Thread (1 message) 1 message, 1 author, 2020-10-08

Re: [PATCH v2] userdiff: expand detected chunk headers for css

From: Junio C Hamano <hidden>
Date: 2020-10-08 17:23:47

"Sohom Datta via GitGitGadget" [off-list ref] writes:
From: Sohom <redacted>
I'd call this line *1* for later reference...
The regex used for the CSS builtin diff driver in git is only
able to show chunk headers for lines that start with a number,
a letter or an underscore.

However, the regex fails to detect classes (starts with a .), ids
(starts with a #), :root and attribute-value based selectors (for
example [class*="col-"]), as well as @based block-level statements
like @page,@keyframes and @media since all of them, start with a
special character.

Allow the selectors and block level statements to begin with these
special characters.

Signed-off-by: Sohom Datta <redacted>
---
Looking good.

The "Name <email>" on line *1* must match that on the last
"signed-off-by" line, so I'll locally tweak the authorship information
before applying the patch.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help