Thread (1 message) 1 message, 1 author, 2020-10-02

Re: [PATCH v9 1/3] push: add reflog check for "--force-if-includes"

From: Junio C Hamano <hidden>
Date: 2020-10-02 16:26:52

Johannes Schindelin [off-list ref] writes:
I can verify that the multiple calls to `in_merge_bases_many()` lead to a
problem ...
Is it because it forgets to clear the marks?  I do not think so.
Besides the sample history demonstrated by the failing test were so
small that it didn't need multiple calls, IIRC.  There was a trivial
bug in the function when commit-graph was enabled and there is no
reason to avoid calling the function multiple times, right?

I just wanted to make sure that a "in-merge-bases-many cannot be
called twice" myth does not get etched in the archive.

Thanks for solving the puzzle with Derrick, by the way.  Very much
appreciated.  I was wondering if my CC'ing commit-graph folks were
somehow not reaching the intended recipients.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help