Thread (2 messages) 2 messages, 2 authors, 2020-09-29

Re: [PATCH v2 2/3] credentials: make line reading Windows compatible

From: Jeff King <hidden>
Date: 2020-09-29 03:00:45

On Mon, Sep 28, 2020 at 05:54:37PM -0700, Junio C Hamano wrote:
Jeff King [off-list ref] writes:
quoted
Yeah, that is probably what would happen. I have to admit that it's such
an obscure case that I'm not sure I really care. It's unlikely in
practice, and if somebody did report such a case, I think my first
response would be "well, why did you have a broken entry stuck in your
file?".
I think we know the likely answer.  "I once used Windows to edit the
file manually".

After which the file looks broken, so the user may have re-added via
the credential API (with LF line ending) a new entry for the host
and have been happily using the result.
I wrote something less charitable towards the user at first, and then
toned it down. But I think I toned it down too much. Maybe my response
would be "garbage in, garbage out; it was lucky that it worked before".

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help