Thread (62 messages) flat view 62 messages, 6 authors, 2020-09-30

Re: [PATCH 07/10] cmake (Windows): complain when encountering an unknown compiler

From: Johannes Schindelin <hidden>
Date: 2020-09-26 20:33:51

Hi Sibi,

On Fri, 25 Sep 2020, Sibi Siddharthan wrote:
On Fri, Sep 25, 2020 at 7:58 PM Johannes Schindelin via GitGitGadget
[off-list ref] wrote:
quoted
From: Johannes Schindelin <redacted>

We have some custom handling regarding the link options, which are
specific to each compiler.

Therefore: let's not just continue without setting the link options when
configuring for a currently unhandled compiler, but error out.

Note: for some reason, the `invalidcontinue.obj` trick seems not to work
in this developer's hands when building Git in Debug mode: the assertion
dialog that is supposed to be suppressed still pops up, complaining
about the `entry` variable being uninitialized when it is used in
`config.c`'s line 1961.
Does this happen when running Git under the Visual Studio debugger?
Whoops. I meant to remove this paragraph after addressing that `run-time
check failure #3` problem.

Will remove it before sending the next iteration.

Thanks,
Dscho
If so this might help
_CrtSetReportMode(_CRT_ASSERT,0);

After digging a bit more I found out that _CRTDBG_MODE_DEBUG is
environment sensitive.
It depends on how the debugger handles DbgPrintEx().

Thank You,
Sibi Siddharthan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help