Re: [PATCH v3 4/8] midx: enable core.multiPackIndex by default

On 9/22/2020 7:16 PM, Jonathan Tan wrote:

quoted

diff --git a/repository.h b/repository.h
index 3c1f7d54bd..3901ce0b65 100644
--- a/repository.h
+++ b/repository.h

@@ -37,6 +37,8 @@ struct repo_settings {
 
 	int pack_use_sparse;
 	enum fetch_negotiation_setting fetch_negotiation_algorithm;
+
+	int core_multi_pack_index;

The only thing I noticed here is why this isn't a bit ("unsigned
core_multi_pack_index : 1"), but I guess it is consistent with "int
pack_use_sparse".

The _real_ reason is that we initialize these to -1 in
prepare_repo_settings() so UPDATE_DEFAULT_BOOL() knows that
the setting was not populated by a config value.

Thanks,
-Stolee