Thread (1 message) 1 message, 1 author, 2020-09-23

Re: [PATCH v4 1/3] push: add reflog check for "--force-if-includes"

From: Junio C Hamano <hidden>
Date: 2020-09-23 16:47:13

Srinidhi Kaushik [off-list ref] writes:
quoted
quoted
  - check if the remote ref is reachable from any of the local ref's
    "reflog" entries using "in_merge_bases_many()" in batches as
    suggested here.
I think it amounts to the same as "does any reflog entry of HEAD
reach it?" and shares the same issues with false positives as the
first one.
Hmm, isn't this the same as what was mentioned by you earlier (without
the timestamp:
I misunderstood what you meant with the "any of the local ref" part
of the sentence and mistook it as "enumerate all the local refs and
HEAD, and collect all reflog entries of these local refs, and see if
any of them reach the remote ref".  Re-reading the sentence with
that "any of" refers to "entries" (of a single local ref) in mind,
it is pretty much the same as we agreed is a good way to go.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help