Thread (9 messages) flat view 9 messages, 2 authors, 2020-09-23
STALE2157d

Revision v8 of 2 in this series.

Revisions (2)
  1. v8 current
  2. v9 [diff vs current]

[PATCH v8 5/6] bisect: call 'clear_commit_marks_all()' in 'bisect_next_all()'

From: Miriam Rubio <hidden>
Date: 2020-09-23 07:28:12
Subsystem: the rest · Maintainer: Linus Torvalds

As there can be other revision walks after bisect_next_all(),
let's add a call to a function to clear all the marks at the
end of bisect_next_all().

Mentored-by: Christian Couder [off-list ref]
Signed-off-by: Miriam Rubio <redacted>
---
 bisect.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/bisect.c b/bisect.c
index d42a3a3767..c6aba2b9f2 100644
--- a/bisect.c
+++ b/bisect.c
@@ -1082,6 +1082,8 @@ enum bisect_error bisect_next_all(struct repository *r, const char *prefix)
 		  "Bisecting: %d revisions left to test after this %s\n",
 		  nr), nr, steps_msg);
 	free(steps_msg);
+	/* Clean up objects used, as they will be reused. */
+	clear_commit_marks_all(ALL_REV_FLAGS);
 
 	return bisect_checkout(bisect_rev, no_checkout);
 }
-- 
2.25.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help