Re: [PATCH v4 3/3] ci: stop linking built-ins to the dashed versions
From: Junio C Hamano <hidden>
Date: 2020-09-21 22:53:21
"Johannes Schindelin via GitGitGadget" [off-list ref] writes:
From: Johannes Schindelin <redacted> Since e4597aae6590 (run test suite without dashed git-commands in PATH, 2009-12-02), we stopped running our tests with `git-foo` binaries found at the top-level directory of a freshly built source tree; instead we have placed only `git` and selected `git-foo` commands that must be on `$PATH` in `bin-wrappers/` and prepended that `bin-wrappers/` to the `PATH` used in the test suite. We did that to catch the tests and scripted Git commands that still try to use the dashed form. Since CI jobs will not install the built Git to anywhere, and the hardlinks we make at the top-level of the source tree for `git-add` and friends are not even used during tests, they are pure waste of resources these days.
Makes perfect sense, and I do not think readers will confused like they were by the previous round's corresponding step.
quoted hunk
diff --git a/ci/lib.sh b/ci/lib.sh index 3eefec500d..821e3660d6 100755 --- a/ci/lib.sh +++ b/ci/lib.sh@@ -178,6 +178,7 @@ fi export DEVELOPER=1 export DEFAULT_TEST_TARGET=prove export GIT_TEST_CLONE_2GB=true +export SKIP_DASHED_BUILT_INS=YesPlease
OK. This would hopefully cover all the CI targets; we know it covers everybody who uses DEVELOPER=1, which is a good sign ;-) Thanks.