On Mon, Sep 21, 2020 at 2:05 PM Phillip Wood [off-list ref] wrote:

On 21/09/2020 16:43, Eric Sunshine wrote:

quoted

Nit: It feels a bit odd (though not outright wrong) to disallow
--reword in combination with --amend and --only after the
documentation states that --reword is equivalent to using those
options.

Yeah I decided to be quite strict, I'm in two minds about the
documentation, I think it might be better to remove that line.

I rather like that the documentation explains the equivalency between
--reword and `--amend --only --allow-empty` since it makes --reword
less magical and provides the readers with pointers for further study.

I decided to use the C_LOCALE_OUTPUT prerequisite and test_cmp rather
than grep so I could check the exact output. [...]

I overlooked C_LOCALE_OUTPUT.