Re: [PATCH 1/2] config: improve error message for boolean config
From: Jeff King <hidden>
Date: 2020-09-18 18:10:28
On Fri, Sep 18, 2020 at 02:17:06AM +0000, Andrew Klotz via GitGitGadget wrote:
quoted hunk ↗ jump to hunk
diff --git a/t/t0205-gettext-poison.sh b/t/t0205-gettext-poison.sh index f9fa16ad83..b66d34c6f2 100755 --- a/t/t0205-gettext-poison.sh +++ b/t/t0205-gettext-poison.sh@@ -33,7 +33,7 @@ test_expect_success 'eval_gettext: our eval_gettext() fallback has poison semant test_expect_success "gettext: invalid GIT_TEST_GETTEXT_POISON value doesn't infinitely loop" " test_must_fail env GIT_TEST_GETTEXT_POISON=xyz git version 2>error && - grep \"fatal: bad numeric config value 'xyz' for 'GIT_TEST_GETTEXT_POISON': invalid unit\" error + grep \"fatal: bad boolean config value 'xyz' for 'GIT_TEST_GETTEXT_POISON'\" error "
This test is pretty subtle and depends on gettext-poison's inner workings. I wonder if it's worth adding a separate: git config --bool --default=foo does.not.exist test in t1300 or similar. -Peff