Thread (1 message) 1 message, 1 author, 2020-09-17

Re: [PATCH] config: option transfer.ipversion to set transport protocol version for network fetches

From: Junio C Hamano <hidden>
Date: 2020-09-17 00:57:16

Jeff King [off-list ref] writes:
quoted hunk
My suggestion elsewhere was to have an "unset" value, and then resolve
it at the time-of-use, something like:
diff --git a/transport.c b/transport.c
index 43e24bf1e5..6414a847ae 100644
--- a/transport.c
+++ b/transport.c
@@ -248,6 +248,9 @@ static int connect_setup(struct transport *transport, int for_push)
 	if (data->conn)
 		return 0;
 
+	if (transport->family == TRANSPORT_FAMILY_UNSET)
+		transport->family = transport_family_config;
+
Ah, OK, if we want to configure it the other way around, yes, we
need "the command line didn't say any" value.  The context of the
"elsewhere" discussion was wnat I was missing (I'd happily blame
vger for not delivering mails in order ;-).
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help