Thread (1 message) 1 message, 1 author, 2020-09-14

Re: [PATCH] builtin/clone: avoid failure with GIT_DEFAULT_HASH

From: Junio C Hamano <hidden>
Date: 2020-09-14 21:37:27

"brian m. carlson" [off-list ref] writes:
quoted
Alternatively, I certainly wouldn't complain if you did introduce a new
function and updated the call-site that passes reinit as 1.
I thought about introducing a new function, but since it would share
almost all of the code, it seemed a bit wasteful, even if the function
is small.  We do have only two callers, I believe, since I recall
making this function non-static and calling it from clone, so I think
it's okay.
Perhaps.

FWIW, this seems to have strange interaction with something in
'seen' when merged; I suspect it is the topic that mucks with the
set-up sequence for "git clone", but didn't check.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help