Re: sub-fetches discard --ipv4|6 option
From: Junio C Hamano <hidden>
Date: 2020-09-14 20:06:38
Alex Riesen [off-list ref] writes:
quoted hunk
diff --git a/builtin/fetch.c b/builtin/fetch.c index 82ac4be8a5..5e06c07106 100644 --- a/builtin/fetch.c +++ b/builtin/fetch.c@@ -1531,6 +1531,10 @@ static void add_options_to_argv(struct argv_array *argv) argv_array_push(argv, "-v"); else if (verbosity < 0) argv_array_push(argv, "-q"); + if (family == TRANSPORT_FAMILY_IPV4) + argv_array_push(argv, "--ipv4"); + else if (family == TRANSPORT_FAMILY_IPV6) + argv_array_push(argv, "--ipv6"); }Am I missing something obvious?
I think something obvious was missed back wne -4/-6 was added at c915f11e (connect & http: support -4 and -6 switches for remote operations, 2016-02-03) ;-). The other candidate was 9c4a036b (Teach the --all option to 'git fetch', 2009-11-09) that introduced this helper to relay various options, but back then there weren't -4/-6 invented yet, so... It is somewhat sad that we need to manually relay these down, but I do not offhand think of a way to automate this sensibly. Thanks for noticing.