Re: [PATCH v4 8/9] commit: use config-based hooks

Phillip Wood [off-list ref] writes:

quoted

+	const char *arg;
+	struct strvec hook_args = STRVEC_INIT;
+	struct strbuf hook_name = STRBUF_INIT;
  	int ret;
  +	strbuf_addstr(&hook_name, name);

Seeing this makes me wonder if it would be better for run_hooks() to
take a string for the name rather than an strbuf, I suspect that
virtually all callers have a fixed hook name.

Yeah, that is a good point.  It is always a good discipline to keep
the type of the parameters callers need to pass to the minimum.