[PATCH v7 01/13] bisect--helper: BUG() in cmd_*() on invalid subcommand
From: Miriam Rubio <hidden>
Date: 2020-08-31 10:51:31
Subsystem:
the rest · Maintainer:
Linus Torvalds
From: Miriam Rubio <hidden>
Date: 2020-08-31 10:51:31
Subsystem:
the rest · Maintainer:
Linus Torvalds
In cmd_bisect__helper() function, if an invalid or no subcommand is passed there is a BUG. BUG() out instead of returning an error. Mentored-by: Christian Couder [off-list ref] Mentored-by: Johannes Schindelin [off-list ref] Signed-off-by: Miriam Rubio <redacted> --- builtin/bisect--helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
index cdda279b23..f464e95792 100644
--- a/builtin/bisect--helper.c
+++ b/builtin/bisect--helper.c@@ -720,7 +720,7 @@ int cmd_bisect__helper(int argc, const char **argv, const char *prefix) res = bisect_start(&terms, argv, argc); break; default: - return error("BUG: unknown subcommand '%d'", cmdmode); + BUG("unknown subcommand %d", cmdmode); } free_terms(&terms);
--
2.25.0