Thread (1 message) 1 message, 1 author, 2020-08-21

Re: [PATCH] ident: say whose identity is missing when giving user.name hint

From: Junio C Hamano <hidden>
Date: 2020-08-21 22:35:13

Eric Sunshine [off-list ref] writes:
On Fri, Aug 21, 2020 at 5:31 PM Alvaro Aleman [off-list ref] wrote:
quoted
One nit though: There is no `--committer` flag for `git commit`,
Indeed, that `--committer=` was a last-second edit (without checking
docs).
Yeah, I forgot that we deliberately omit the command line option for
the committer info.
How about this?

    If `user.name` and `user.email` have not been configured and the
    user invokes:

        git commit --author=...

    without specifying the committer, then Git errors out with a
    message asking the user to configure `user.name` and `user.email`
    but doesn't tell the user which attribution was missing. This can
    be confusing for a user new to Git who isn't aware of the
    distinction between user, author, and committer.  Give such users
    a bit more help by extending the error message to also say which
    attribution is expected.
OK.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help