Thread (1 message) 1 message, 1 author, 2020-08-20

Re: [PATCH 2/7] maintenance: store the "last run" time in config

From: Đoàn Trần Công Danh <hidden>
Date: 2020-08-20 14:34:57

On 2020-08-19 17:16:43+0000, Derrick Stolee via GitGitGadget [off-list ref] wrote:
From: Derrick Stolee <redacted>

Users may want to run certain maintenance tasks only so often. Update
the local config with a new 'maintenance.<task>.lastRun' config option
that stores the timestamp just before running the maintenance task.

I selected the timestamp before the task, as opposed to after the task,
for a couple reasons:

 1. The time the task takes to execute should not contribute to the
    interval between running the tasks. If a daily task takes 10 minutes
    to run, then every day the execution will drift by at least 10
    minutes.

 2. If the task fails for some unforseen reason, it would be good to
    indicate that we _attempted_ the task at a certain timestamp. This
    will avoid spamming a repository that is in a bad state.

Signed-off-by: Derrick Stolee <redacted>
---
 Documentation/config/maintenance.txt |   5 +++++
 builtin/gc.c                         |  16 ++++++++++++++++
 git-gvfs-helper                      | Bin 0 -> 11171736 bytes
 t/helper/test-gvfs-protocol          | Bin 0 -> 10946928 bytes
Look like those 2 files should be added into .gitignore, no?

-- 
Danh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help