Re: [PATCH] fast-export: factor out print_oid()

Jeff King [off-list ref] writes:

On Sat, Aug 15, 2020 at 09:14:49AM +0200, René Scharfe wrote:

quoted

quoted

I think this is a bad direction unless you're going to do it for all of
the other anonymize_*() functions, as well, for consistency. And there
it gets tricky because the caller is able to use the anonymizing
knowledge in more places.

I actually liked your original version better.

OK, how about embracing the static and do something like this?

-- >8 --
Subject: [PATCH] fast-export: add format_oid() and format_path()

TBH, I don't find it an improvement because of the extra buffer
handling. But I admit that I don't really care between any of the
solutions posted here. They all appear to be correct, and just trading
off various properties so that none is definitively better than the
other. (And none of them is so bad that I feel compelled to avoid it).

So I'd be OK with any of them (or leaving it as-is).

-Peff

I've marked it as "retracted" per
https://lore.kernel.org/git/6e2d4472-8293-4f10-0ba6-82ae83f7a465@web.de/ (local)

Thanks.