Thread (28 messages) 28 messages, 3 authors, 2020-08-10

Re: [PATCH v2 04/11] t6416, t6422: fix incorrect untracked file count

From: Eric Sunshine <hidden>
Date: 2020-08-09 03:12:17

On Sat, Aug 8, 2020 at 1:01 PM Elijah Newren via GitGitGadget
[off-list ref] wrote:
Apparently I don't know how to count untracked files, and since the tests
in question were marked as test_expect_failure, no one every noticed it
until know.  Correct the count, as these tests clearly creates three
untracked files ('out', 'err', and 'file_count').
s/every/ever/
s/know/now/
s/creates/create/
(I believe this problem arose because earlier incarnations counted lines
via a pipe to 'wc -l'.  Reviewers asked that it be replaced by writing
the output to a file and using test_line_count, but when the temporary
output was added to a separate file, the count of untracked files should
have increased.)

Signed-off-by: Elijah Newren <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help