Thread (1 message) 1 message, 1 author, 2020-08-07

Re: "#define precompose_argv(c,v) /* empty */" is evil

From: Junio C Hamano <hidden>
Date: 2020-08-07 06:42:52

Jeff King [off-list ref] writes:
quoted
Yes, of course, but as I wrote in my response to Brian, the whole
point of using these replacement implementation macros is so that we
do not have to sprinkle the main code with such #ifdef/#endif, so
I think the code like that is what needs to be corrected ;-)
I'm not sure if I made my point clearly. ...
Sorry, indeed I missed it.  

Using the implementation of precompose_argv() itself as an example,
instead of generic looking some_func(), does help to explain why at
some point we are bound to have some API calls that are compiled on
some platforms and not on others.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help