Thread (1 message) 1 message, 1 author, 2020-07-25

Re: [PATCH v5 02/13] bisect--helper: use '-res' in 'cmd_bisect__helper' return

From: Junio C Hamano <hidden>
Date: 2020-07-25 23:03:46

Shourya Shukla [off-list ref] writes:
quoted
Following 'enum bisect_error' vocabulary, return variable 'res' is
always non-positive.
Let's use '-res' instead of 'abs(res)' to make the code clearer.
quoted
Mentored-by: Christian Couder [off-list ref]
Signed-off-by: Miriam Rubio <redacted>
Helped-by: Junio C Hamano [off-list ref]
Although there is no set rule for this, but I think that your sign-off
goes at the last generally. This is what I have seen on various patches.
It is most natural to list these entries in chronological order.

Code was written while others helped, and the final seal on what
gets sent out is stamped by appending the author's sign-off at the
end.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help